Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_troubleshooting_message: Include git commit of the vcpkg repo and suggest updating with git pull #197

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort commented Sep 19, 2021

Currently you can only guess if the user is using a recent vcpkg version when a user submits an issue.

@strega-nil-ms
Copy link
Contributor

Is there a reason we aren't just using rev-parse HEAD?

@autoantwort
Copy link
Contributor Author

Because I want to know the date. I want to know if the user is using a recent version of the vcpkg repo or an old one. And only the hash does not help (Yeah I can lookup the commit and check the date, but doing this for every issue is very painful).

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it interact with custom registries or overlay ports? They may change the given port and/or dependencies.

src/vcpkg/build.cpp Outdated Show resolved Hide resolved
@autoantwort
Copy link
Contributor Author

How does it interact with custom registries or overlay ports? They may change the given port and/or dependencies.

Thats right, my ultimate goal is that vcpkg outputs a ready to copy paste github issue markdown code. In that you can then also put config files and other important information. The only problem currently is to catch the error logs. They are printed here:
https://github.com/microsoft/vcpkg/blob/827a54c404e67205262e6db032fb2c1a5e6fd097/scripts/cmake/vcpkg_execute_required_process.cmake#L132
I would simply search for the See logs for more information string but I assume @strega-nil-ms wants a guid based solution?

src/vcpkg/build.cpp Outdated Show resolved Hide resolved
@autoantwort
Copy link
Contributor Author

@BillyONeal can you do the second review ? :)

@BillyONeal BillyONeal merged commit 909c2ba into microsoft:main Oct 12, 2021
@autoantwort autoantwort deleted the improve-shown-information branch November 7, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants