[filesystem] Make remove_all remove directories that aren't writable on POSIX. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on POSIX. Observe this before and after: ``` @BillyONeal ➜ /workspaces/vcpkg (download-script) $ ./vcpkg install crossguid Computing installation plan... The following packages will be built and installed: crossguid[core]:x64-linux -> 0.2.2-2018-06-16#2 * libuuid[core]:x64-linux -> 1.0.3#8 Additional packages (*) will be modified to complete this operation. Detecting compiler hash for triplet x64-linux... Restored 2 packages from /home/codespace/.cache/vcpkg/archives in 5.092 ms. Use --debug to see more details. Starting package 1/2: libuuid:x64-linux Installing package libuuid[core]:x64-linux... Elapsed time for package libuuid:x64-linux: 1.517 ms Starting package 2/2: crossguid:x64-linux Installing package crossguid[core]:x64-linux... Elapsed time for package crossguid:x64-linux: 1.12 ms Total elapsed time: 352.8 ms The package crossguid provides CMake targets: find_package(crossguid CONFIG REQUIRED) target_link_libraries(main PRIVATE crossguid) @BillyONeal ➜ /workspaces/vcpkg (download-script) $ ./vcpkg remove crossguid The following packages will be removed: crossguid:x64-linux Removing package crossguid:x64-linux... Failure to remove_all("/workspaces/vcpkg/packages/crossguid_x64-linux") due to file "/workspaces/vcpkg/packages/crossguid_x64-linux/include/crossguid/guid.hpp": Permission denied @BillyONeal ➜ /workspaces/vcpkg (download-script) $ ../vcpkg-tool/build/vcpkg remove crossguid The following packages are not installed, so not removed: crossguid:x64-linux Package crossguid:x64-linux is not installed @BillyONeal ➜ /workspaces/vcpkg (download-script) $ ../vcpkg-tool/build/vcpkg x-ci-clean Starting vcpkg CI clean Clearing contents of /workspaces/vcpkg/buildtrees Clearing contents of /workspaces/vcpkg/installed Clearing contents of /workspaces/vcpkg/packages Completed vcpkg CI clean @BillyONeal ➜ /workspaces/vcpkg (download-script) $ ./vcpkg install crossguid Computing installation plan... The following packages will be built and installed: crossguid[core]:x64-linux -> 0.2.2-2018-06-16#2 * libuuid[core]:x64-linux -> 1.0.3#8 Additional packages (*) will be modified to complete this operation. Detecting compiler hash for triplet x64-linux... Restored 2 packages from /home/codespace/.cache/vcpkg/archives in 5.771 ms. Use --debug to see more details. Starting package 1/2: libuuid:x64-linux Installing package libuuid[core]:x64-linux... Elapsed time for package libuuid:x64-linux: 1.752 ms Starting package 2/2: crossguid:x64-linux Installing package crossguid[core]:x64-linux... Elapsed time for package crossguid:x64-linux: 1.334 ms Total elapsed time: 347.1 ms The package crossguid provides CMake targets: find_package(crossguid CONFIG REQUIRED) target_link_libraries(main PRIVATE crossguid) @BillyONeal ➜ /workspaces/vcpkg (download-script) $ ../vcpkg-tool/build/vcpkg remove crossguid The following packages will be removed: crossguid:x64-linux Removing package crossguid:x64-linux... @BillyONeal ➜ /workspaces/vcpkg (download-script) $ ```
strega-nil-ms
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observe this before and after: