Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x-add-version] ignore files in ports dir #257

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

autoantwort
Copy link
Contributor

This was the behavior before #126 got merged. This also solves microsoft/vcpkg#16520 (comment)

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that this is actually a change in #126, before and after in that change files are enumerated, but I still think this change is OK.

@autoantwort
Copy link
Contributor Author

Yeah you are right. But something changed. The output Found both manifest and CONTROL file in port /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/ports/.DS_Store; please rename one or the other does not make sense. .DS_Store is a file and not a folder. It is impossible that in this "folder" are a CONTROL and manifest file.

@autoantwort
Copy link
Contributor Author

Ok the real problem seems to be that fs.exists is broken on posix. So fs.exists(/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/ports/.DS_Store/vcpkg.json, VCPKG_LINE_INFO) outputs exists(/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/ports/.DS_Store/vcpkg.json): Not a directory instead of returning false.

@BillyONeal
Copy link
Member

That sounds identical to the problem fixed in 78bc405 ... any chance you don't have that change in what you're testing?

@autoantwort
Copy link
Contributor Author

Yeah I haven't that change. It is fixed now.

@BillyONeal BillyONeal merged commit 3b80230 into microsoft:main Nov 9, 2021
@BillyONeal
Copy link
Member

Thanks!

@autoantwort autoantwort deleted the x-add-version-fix-.DS_Store branch February 5, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants