Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return verbose error when json contains object with duplicated keys #262

Merged

Conversation

stforek
Copy link
Contributor

@stforek stforek commented Nov 10, 2021

Fixes microsoft/vcpkg#20837.

It looks that parsing vcpkg.json may require more error handling.

@ghost
Copy link

ghost commented Nov 10, 2021

CLA assistant check
All CLA requirements met.

@stforek stforek force-pushed the json-parse-duplicated-field-names branch from de512d6 to 5432347 Compare November 10, 2021 14:24
@ras0219-msft ras0219-msft merged commit 8ad3973 into microsoft:main Nov 10, 2021
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg] vcpkg crashed if there are the same fileds in vcpkg.json
3 participants