Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for AWS S3 binary caching #293

Merged
merged 5 commits into from
Jan 13, 2022
Merged

Adding support for AWS S3 binary caching #293

merged 5 commits into from
Jan 13, 2022

Conversation

dave-juicelabs
Copy link
Contributor

No description provided.

@dave-juicelabs
Copy link
Contributor Author

While this is being reviewed, is there a way for me to use this in my own personal builds? Since vcpkg now downloads a built version, I am unsure of how I would be able to integrate this.

@mathisloge
Copy link
Contributor

While this is being reviewed, is there a way for me to use this in my own personal builds? Since vcpkg now downloads a built version, I am unsure of how I would be able to integrate this.

you can just replace the downloaded version of vcpkg with your built version

strega-nil-ms
strega-nil-ms suggested changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, but otherwise, this looks great :)

src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/tools.cpp Outdated Show resolved Hide resolved
@strega-nil-ms
Copy link
Contributor

cc @ras0219-msft as the owner of binary caching.

@dave-juicelabs
Copy link
Contributor Author

Ahh, yeah that looks a lot more reasonable.

@PhoebeHui PhoebeHui mentioned this pull request Dec 22, 2021
Closed
@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pospelove
Copy link
Contributor

Can't wait for AWS S3 support :)

ras0219-msft
ras0219-msft approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this also will require adding the AWS CLI to vcpkgTools.xml in the vcpkg repo.

Otherwise, LGTM. Thanks for the PR!

@strega-nil-ms
Copy link
Contributor

thanks y'all!

@strega-nil-ms strega-nil-ms merged commit 018d568 into microsoft:main Jan 13, 2022
@BillyONeal BillyONeal mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms requested changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees

@ras0219-msft ras0219-msft

@strega-nil-ms strega-nil-ms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dave-juicelabs @mathisloge @strega-nil-ms @ras0219-msft @Pospelove @damcclos @strega-nil