upgrade: Make --keep-going the default #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this choice; however, it definitely requires discussion. |
strega-nil-ms
added
the
requires:discussion
strega-nil-ms
suggested changes
Jan 6, 2022
src/vcpkg/commands.upgrade.cpp
Outdated
| {OPTION_NO_DRY_RUN, "Actually upgrade"}, | ||
| {OPTION_KEEP_GOING, "Continue installing packages on failure"}, | ||
| {OPTION_KEEP_GOING, "The default (deprecated)"}, |
There was a problem hiding this comment.
Suggested change
| {OPTION_KEEP_GOING, "The default (deprecated)"}, | |
| {OPTION_KEEP_GOING, "Continue installing packages on failure (default)"}, |
src/vcpkg/commands.upgrade.cpp
Outdated
| {OPTION_NO_DRY_RUN, "Actually upgrade"}, | ||
| {OPTION_KEEP_GOING, "Continue installing packages on failure"}, | ||
| {OPTION_KEEP_GOING, "The default (deprecated)"}, | ||
| {OPTION_STOP_AT_FAILURE, "Stop installing packages on failure"}, |
There was a problem hiding this comment.
Suggested change
| {OPTION_STOP_AT_FAILURE, "Stop installing packages on failure"}, | |
| {OPTION_NO_KEEP_GOING, "Stop installing packages on failure"}, |
src/vcpkg/commands.upgrade.cpp
Outdated
Comment on lines
59
to
66
| if (Util::Sets::contains(options.switches, OPTION_KEEP_GOING)) | ||
| { | ||
| print2(Color::warning, | ||
| "The option `", | ||
| OPTION_KEEP_GOING, | ||
| "` is the default now. You don't have to pass this option anymore."); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if (Util::Sets::contains(options.switches, OPTION_KEEP_GOING)) | |
| { | |
| print2(Color::warning, | |
| "The option `", | |
| OPTION_KEEP_GOING, | |
| "` is the default now. You don't have to pass this option anymore."); | |
| } |
it's not standard practice to warn on passing the "default" for an option.
| @@ -54,8 +56,16 @@ namespace vcpkg::Commands::Upgrade | |||
|
|
|||
| const ParsedArguments options = args.parse_arguments(COMMAND_STRUCTURE); | |||
|
|
|||
There was a problem hiding this comment.
Also, make sure that you check for both OPTION_KEEP_GOING and OPTION_NO_KEEP_GOING and error if both are passed.
src/vcpkg/commands.upgrade.cpp
Outdated
| @@ -24,11 +24,13 @@ namespace vcpkg::Commands::Upgrade | |||
|
|
|||
| static constexpr StringLiteral OPTION_NO_DRY_RUN = "no-dry-run"; | |||
| static constexpr StringLiteral OPTION_KEEP_GOING = "keep-going"; | |||
| static constexpr StringLiteral OPTION_STOP_AT_FAILURE = "stop-at-failure"; | |||
There was a problem hiding this comment.
Suggested change
| static constexpr StringLiteral OPTION_STOP_AT_FAILURE = "stop-at-failure"; | |
| static constexpr StringLiteral OPTION_NO_KEEP_GOING = "no-keep-going"; |
this is the standard.
strega-nil-ms
added
requires:author-response
and removed
requires:discussion
BillyONeal
approved these changes
Feb 12, 2022
strega-nil-ms
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17922