Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock VCPKG_BASE_VERSION in the first job for use in subsequent jobs. #346

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Feb 9, 2022

The "2022-02-01" release is broken because the CE build thought the date was 2022-01-31, while the vcpkg.exe build thought it was 2022-02-01. See https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=5694458&view=results

The pipeline.startTime variable appears to be reevaluated each time a job starts, and refers to the job start time, not the overall pipeline start time, so when a build crosses 4PM pacific time it produced broken output.

This change gets the first arch_independent stage to write the value it used, and this is fed into the remaining stages.

The "2022-02-01" release is broken because the CE build thought the date was 2022-01-31, while the vcpkg.exe build thought it was 2022-02-01. See https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=5694458&view=results

The pipeline.startTime variable appears to be reevaluated each time a job starts, and refers to the *job* start time, not the overall pipeline start time, so when a build crosses 4PM pacific time it produced broken output.

This change gets the first arch_independent stage to write the value it used, and this is fed into the remaining stages.
@BillyONeal
Copy link
Member Author

I didn't let the pipeline this is attached to run to completion because it would have tried to create a GitHub release we don't want, but I did ensure the version is passed into downstream stages before submitting this: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5729233&view=results

@strega-nil-ms
Copy link
Contributor

@BillyONeal I see that VCPKG_INITIAL_BASE_VERSION is set to 2022-01-01; is that correct here?

@BillyONeal
Copy link
Member Author

@BillyONeal I see that VCPKG_INITIAL_BASE_VERSION is set to 2022-01-01; is that correct here?

Yes I used the "override" button in that test; I wanted something that would be clearly bogus if it accidentally ran to completion. It needs to look like a date to pass some of our validity checks.

@strega-nil-ms
Copy link
Contributor

strega-nil-ms commented Feb 10, 2022

@BillyONeal can you try it without doing the override? I want to see those results as well, just to make sure. I believe that if the pipeline runs to completion it only creates a draft release, anyways, that no one outside the team can see

@BillyONeal
Copy link
Member Author

@BillyONeal can you try it without doing the override? I want to see those results as well, just to make sure. I believe that if the pipeline runs to completion it only creates a draft release, anyways, that no one outside the team can see

Unfortunately manually triggering a build requires setting an overriding value.

@BillyONeal BillyONeal merged commit 5ba4532 into microsoft:main Feb 11, 2022
@BillyONeal BillyONeal deleted the timestamp branch February 11, 2022 06:33
strega-nil-ms pushed a commit to strega-nil/vcpkg-tool that referenced this pull request Feb 12, 2022
…icrosoft#346)

The "2022-02-01" release is broken because the CE build thought the date was 2022-01-31, while the vcpkg.exe build thought it was 2022-02-01. See https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=5694458&view=results

The pipeline.startTime variable appears to be reevaluated each time a job starts, and refers to the *job* start time, not the overall pipeline start time, so when a build crosses 4PM pacific time it produced broken output.

This change gets the first arch_independent stage to write the value it used, and this is fed into the remaining stages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants