-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check to ensure loaded port matches the declared version #347
Add check to ensure loaded port matches the declared version #347
Conversation
I think investigating what happened was high priority but this has been in the product for more than a year, so I don't think avoiding adding the e2e test to get it a day or 2 earlier is reasonable. As for not printing duplicates, isn't that a call to |
It was, and I pushed that. |
Localizing the error message changed the content which made the e2e test fail, I pushed a fix. |
…ft#347) * Add check to ensure loaded port matches the declared version * Dedupe errors. * Add end to end regression test. * Localize error * Remove e2e test dependency on Microsoft/vcpkg * Fixup localized error check. * Fix format-cxxcode on VS2022 machines, add message map. Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Fixes microsoft/vcpkg#20503.
The fundamental issue in the thread was that the user's versions database did not match the actual retrieved files. This PR addresses the problem by adding an integrity check to ensure that files retrieved from a registry match the version declared in that registry's database files.
Before:
After:
The error is emitted twice because it is checked every time the algorithm attempts to load the file. The errors are accumulated and presented at once, which currently results in duplication.
Potential improvements to this PR: