Teach Catch2 about LocalizedString and move out of namespace msg. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespace msg is necessary for localized stuff to:
1. Give {formatter} parameters pretty short names without stepping on things.
2. To distinguish the localization safe versions and localization unsafe version of things e.g. vcpkg::println vs msg::println.println.
LocalizedString doesn't fall into any of these categories, and as we start passing them around in more places adding msg:: is annoying, and encourages "using namespace"s that harm (1) and (2).
BillyONeal
commented
Feb 26, 2022
|
|
||
| inline const char* to_printf_arg(const msg::LocalizedString& s) { return s.data().c_str(); } | ||
|
|
||
| struct LocalizedStringMapLess |
There was a problem hiding this comment.
This struct was not used and suggested that LocalizedString has no natural ordering which isn't true.
|
I sucked this change out of the command line parser overhaul. |
strega-nil-ms
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace msg is necessary for localized stuff to:
LocalizedString doesn't fall into any of these categories, and as we start passing them around in more places adding msg:: is annoying, and encourages "using namespace"s that harm (1) and (2).