Read msiexec output as UTF-16. #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently our PR and CI builds in the catalog repo are failing with the message: ```` Extracting 7zip... msiexec failed while extracting 'D:\downloads\7z1900-x64.msi' with message: T ##[error]vcpkg ci failed ```` Example: https://dev.azure.com/vcpkg/public/_build/results?buildId=68039&view=logs&j=7922e5c4-0103-5f8f-ad17-45ce9bb98e80&t=491b9f02-7edc-5990-cda1-511e95a3768e The single character combined with msiexec being a Windows application suggests that it is trying to print UTF-16. This change adds a new Encoding parameter to our cmd_execute_Xxx functions and passes in UTF-16 for msiexec.
…n talking about subprocesses.
strega-nil-ms
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our PR and CI builds in the catalog repo are failing with the message:
Example: https://dev.azure.com/vcpkg/public/_build/results?buildId=68039&view=logs&j=7922e5c4-0103-5f8f-ad17-45ce9bb98e80&t=491b9f02-7edc-5990-cda1-511e95a3768e
The single character combined with msiexec being a Windows application suggests that it is trying to print UTF-16.
This change adds a new Encoding parameter to our cmd_execute_Xxx functions and passes in UTF-16 for msiexec.