Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[localize] checks.h #401

Merged
merged 4 commits into from
Mar 4, 2022
Merged

[localize] checks.h #401

merged 4 commits into from
Mar 4, 2022

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Mar 1, 2022 •
edited by strega-nil-ms
Loading

  • rename Checks::* taking Message types to msg_*
    • this allows us to differentiate between old-style and new-style via grep
  • also flip over stuff to using ^
  • additionally, rename from_string_unchecked to from_raw, and add:
    • append_raw - equivalent to append(from_raw(...))
    • append_indent - equivalent to append(from_raw(" "))
    • append(m, args...) - equivalent to append(format(m, args...))

@strega-nil
rename Checks::* taking Message types to msg_*
5afd923 
this allows us to differentiate between old-style and new-style via grep
@strega-nil
flip over more stuff to localized
41143f7 
* base/hash
* base/unicode
* commands.add
@strega-nil
more changes woot
def91bd
@strega-nil
fix build on unix
d88da07
@vicroms vicroms merged commit afe5ffe into microsoft:main Mar 4, 2022
@strega-nil strega-nil deleted the localize-checks branch March 8, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strega-nil @vicroms