no lib arch checks for mingw #426
Conversation
The cofffilereader fails when reading .a files with 'Could not find proper second linker member'
|
If we don't have a fix today I think we should revert cb47927 and add it back when it is fixed. (Assuming that change is what created the problem) |
| @@ -27,7 +27,9 @@ namespace vcpkg::Util | |||
| template<class Vec, class Key> | |||
| bool contains(const Vec& container, const Key& item) | |||
| { | |||
| return std::find(container.begin(), container.end(), item) != container.end(); | |||
| using std::begin; | |||
There was a problem hiding this comment.
As an aside, this really doesn't belong in "vectors" anymore.
|
As far as I see, there is no build artifacts, so the only way to test this is to build this manually? |
* Update vcpkg-ce SHA and exclude empty file prettifyJs2Xml.js from signing. by @BillyONeal in microsoft/vcpkg-tool#423 * no lib arch checks for mingw by @autoantwort in microsoft/vcpkg-tool#426 **Full Changelog**: microsoft/vcpkg-tool@2022-03-08...2022-03-09
|
Ok, I tested this and it works fine now. Thanks for the quick fix, @autoantwort |
* Update vcpkg-ce SHA and exclude empty file prettifyJs2Xml.js from signing. by @BillyONeal in microsoft/vcpkg-tool#423 * no lib arch checks for mingw by @autoantwort in microsoft/vcpkg-tool#426 **Full Changelog**: microsoft/vcpkg-tool@2022-03-08...2022-03-09
|
I think this PR caused microsoft/vcpkg#23476. |
I think this PR just fixed (enabled) the check. The new issues are real issues which existed before, but unnoticed. |
|
I agree with dg0yt. We'll need to fix regressions as we find them. |
|
Anyway, I hope we can make a fully test when our executable update. |
The cofffilereader fails when reading .a files with 'Could not find proper second linker member'
Fixes microsoft/vcpkg#23450