[ci] print out the dependencies that were unmet #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI builds: |
ras0219-msft
approved these changes
Mar 29, 2022
BillyONeal
reviewed
Mar 29, 2022
src/vcpkg/build.cpp
Outdated
| DECLARE_AND_REGISTER_MESSAGE(BuildingPackageFailed, | ||
| (msg::spec, msg::build_result), | ||
| "", | ||
| "building package {spec} failed with: {build_result}"); |
There was a problem hiding this comment.
Suggested change
| "building package {spec} failed with: {build_result}"); | |
| "building {spec} failed with: {build_result}"); |
As an aside, I think "package foo" can always be better replaced with just "foo". I know this is a change from the status quo so feel free to say "that's another PR Bill"
BillyONeal
approved these changes
Mar 29, 2022
strega-nil-ms
force-pushed
the
print-cascades
branch
from
12ac658
to
fdc0062
Compare
BillyONeal
approved these changes
Mar 30, 2022
| @@ -55,10 +55,13 @@ namespace vcpkg | |||
| m_data.push_back('\n'); | |||
| return *this; | |||
| } | |||
| LocalizedString& append_indent() | |||
| LocalizedString& append_indent(int indent = 1) | |||
There was a problem hiding this comment.
Suggested change
| LocalizedString& append_indent(int indent = 1) | |
| LocalizedString& append_indent(size_t indent = 1) |
Comment on lines
+60
to
+64
| static const StringLiteral INDENT = " "; | ||
| for (int i = 0; i < indent; ++i) | ||
| { | ||
| m_data.append(INDENT.data(), INDENT.size()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| static const StringLiteral INDENT = " "; | |
| for (int i = 0; i < indent; ++i) | |
| { | |
| m_data.append(INDENT.data(), INDENT.size()); | |
| } | |
| m_data.append(indent * 4, ' '); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important because we have Very Weird Errors where, for example,
ffmpegfails to install withCASCADED_DUE_TO_MISSING_DEPENDENCIES, despite all of ffmpeg's dependencies seeming to be successfully installed.This makes the results look like: