Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for COS binary caching #476

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Adding support for COS binary caching #476

merged 4 commits into from
Apr 12, 2022

Conversation

day253
Copy link
Contributor

@day253 day253 commented Mar 31, 2022

Cloud Object Storage (COS) is a distributed storage service launched by Tencent Cloud. It is readily compatible with AWS S3 APIs, allowing direct access to community tools and plugins with ease. (refer to https://intl.cloud.tencent.com/products/cos)

This PR is to enable vcpkg users to use COS for binary caching.

#435

Any advice for the unitest? I tested the feature locally.

@day253 day253 marked this pull request as draft March 31, 2022 04:16
@day253 day253 marked this pull request as ready for review March 31, 2022 07:48
@day253 day253 marked this pull request as draft March 31, 2022 07:49
@day253 day253 marked this pull request as ready for review March 31, 2022 08:02
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see localizable strings for error messages.

src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
@day253
Copy link
Contributor Author

day253 commented Apr 1, 2022

I would like to see localizable strings for error messages.

All resolved

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
include/vcpkg/base/messages.h Outdated Show resolved Hide resolved
@day253 day253 requested review from vicroms and ras0219-msft April 2, 2022 04:04
@day253
Copy link
Contributor Author

day253 commented Apr 8, 2022

CC @vicroms @ras0219-msft

looking forward to your reply.

@day253
Copy link
Contributor Author

day253 commented Apr 12, 2022

CC @vicroms @ras0219-msft

looking forward to your reply.

@ras0219-msft

@ras0219-msft ras0219-msft merged commit bccfd0d into microsoft:main Apr 12, 2022
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants