-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and localize x-add-version
messages
#489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit
Example messages:
Some comments:
|
This change resulted in a huge performance regression. |
Hmmm... probably because we're now doing git status a zillion times? |
Probably. Running it > 1900 times is not the fastest. Maybe disable this additional check when passing |
I think the fix is to run status a single time on the whole "ports" directory, then use that single output to judge each port. |
Should be fixed in #526 |
This PR adds the following behavior changes:
x-add-version
messages