-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add https binary cache #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
force-pushed
the
https-binary-cache
branch
from
May 25, 2022 12:51
36ddba0
to
a167159
Compare
autoantwort
force-pushed
the
https-binary-cache
branch
from
May 25, 2022 13:16
a167159
to
7819e9a
Compare
vicroms
reviewed
May 25, 2022
http support can be useful when pushing/fetching from internal server |
# Conflicts: # src/vcpkg/binarycaching.cpp
BillyONeal
approved these changes
Jun 13, 2022
Thanks! |
This completely broke binary caching for
Note that |
BillyONeal
added a commit
that referenced
this pull request
Jun 16, 2022
This reverts commit 34c1a13.
This are actually two issues:
I have fixed this two issues in #592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to use gitlab generic packages as binary cache.
We could also allow http.
Maybe we should replace the header field by 'options to curl'. Then the
-u
option or multiple headers could be used.