Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Expected<Unit>. #564

Merged
merged 6 commits into from
Jun 2, 2022
Merged

Introduce Expected<Unit>. #564

merged 6 commits into from
Jun 2, 2022

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented May 27, 2022 •
edited
Loading

  • Adds ExpectedT<Unit, ...> and fixes the place in vcpkgpaths that was abusing optional for this purpose.
  • Delete the several unwraps which had the same effect as value_or_exit, but lost the place where the error happened.
  • Fix other examples like Resolve several ExpectedT<T> problems #511 (comment)

@BillyONeal BillyONeal mentioned this pull request May 27, 2022
Merged
@BillyONeal BillyONeal changed the title Introduce Expected<void>. Introduce Expected<Unit>. Jun 1, 2022
@ras0219-msft ras0219-msft merged commit ea01763 into microsoft:main Jun 2, 2022
@BillyONeal BillyONeal deleted the expected-void branch June 2, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyONeal @ras0219-msft