Change the copyright post-build-lint to require a regular file. #584
Conversation
|
Mostly kf5* ports are affected by this. They are responsible for ~240 hits (on We should add a cmake function that merges all copyright files into a single file |
|
microsoft/vcpkg#19227 (comment). |
|
Now that the vcpkg tool knows about licenses and creates |
BillyONeal
changed the title
BillyONeal
added
the
depends:different-pr
|
Thank you <3 |
|
Depends on microsoft/vcpkg#25759 |
|
@BillyONeal I checked the file lists and didn't find any copyright directory. I think this PR can be merged now? |
Check queued: https://dev.azure.com/vcpkg/public/_build/results?buildId=75362&view=results |
Not found any
|
|
Thanks for your contributions! |
| if (fs.exists(usage_file, IgnoreErrors{})) | ||
| if (fs.is_regular_file(usage_file)) |
There was a problem hiding this comment.
Hm it is a supported use case to use a new vcpkg-tool with an old port via versioning?
There was a problem hiding this comment.
Yes, you will just get a warning if you try to install an old port that was affected by this. Just vcpkg CI will treat it as an error.
Furthermore, I think we shouldn't ever try to support ports that make use of bugs in our tool.
There was a problem hiding this comment.
Yes, that's why post-build checks no longer fail the run
There was a problem hiding this comment.
Furthermore, I think we shouldn't ever try to support ports that make use of bugs in our tool.
That is not our policy. No changes must mean no changes.
There was a problem hiding this comment.
My only concern was that the package has no license file after this change (and that the resulting package changes but the binary hash is the same, but I don't care).
Furthermore, I think we shouldn't ever try to support ports that make use of bugs in our tool.
Totally agree. I just wanted to ask :)
There was a problem hiding this comment.
My only concern was that the package has no license file after this change (and that the resulting package changes but the binary hash is the same, but I don't care).
That is not possible. The copyright file gets installed by cmake. If cmake installed it, it won't be removed. During post build checks we only check that everything is OK but don't clean anything up if something is broken,
There was a problem hiding this comment.
The copyright file gets installed by cmake. If cmake installed it, it won't be removed.
Sorry my mistake. I only read install.cpp and copyright and thought this code installed somehow the license files (actually I know that they are installed by cmake)
|
We're doing a release to pick this up: https://github.com/microsoft/vcpkg-tool/releases/tag/2022-07-21 |
Changes:
usageif it is a regular filecopyrightis a directoryNote:
I checked the file lists for
copyright/. There are some ports that have their "copyright" insidecopyright/and only provide one license file. Therefore, this change breaks some ports. I suggest to create a PR where I fix those ports based on a version of vcpkg based on this PR before this PR gets merged.