Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking binary caching data #597

Merged
merged 17 commits into from
Jun 27, 2022
Merged

Tracking binary caching data #597

merged 17 commits into from
Jun 27, 2022

Conversation

JavierMatosD
Copy link
Contributor

Tracking additional properties related to binary caching. Tracks which services users leverage for binary caching. i.e. aws, gcs, nuget, etc.

@JavierMatosD JavierMatosD marked this pull request as draft June 21, 2022 18:35
@JavierMatosD JavierMatosD marked this pull request as ready for review June 22, 2022 21:51
@BillyONeal
Copy link
Member

I pushed a merge into your branch to pick up #600

Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/visualstudio.cpp Outdated Show resolved Hide resolved
include/vcpkg/binarycaching.h Outdated Show resolved Hide resolved
include/vcpkg/binarycaching.h Outdated Show resolved Hide resolved
include/vcpkg/binarycaching.h Outdated Show resolved Hide resolved
src/vcpkg-test/configparser.cpp Outdated Show resolved Hide resolved
src/vcpkg-test/configparser.cpp Outdated Show resolved Hide resolved
src/vcpkg-test/configparser.cpp Outdated Show resolved Hide resolved
src/vcpkg-test/configparser.cpp Outdated Show resolved Hide resolved
include/vcpkg/binarycaching.h Outdated Show resolved Hide resolved
include/vcpkg/binarycaching.h Outdated Show resolved Hide resolved
Moved function from binarycaching.cpp to configparser.cpp.
Response to PR conversations.
src/vcpkg-test/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg-test/configparser.cpp Outdated Show resolved Hide resolved
src/vcpkg-test/configparser.cpp Outdated Show resolved Hide resolved
@BillyONeal BillyONeal requested a review from vicroms June 24, 2022 21:30
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JavierMatosD and others added 2 commits June 27, 2022 12:54
Co-authored-by: Victor Romero <viromer@microsoft.com>
# Conflicts:
#	src/vcpkg-test/configparser.cpp
@JavierMatosD JavierMatosD merged commit d71291e into main Jun 27, 2022
@JavierMatosD JavierMatosD deleted the track_binary_cache branch June 27, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants