Fix removal instructions for PowerShell #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
fearthecowboy
added a commit
that referenced
this pull request
Jun 28, 2022
…r dependencies) (#604) * [vcpkg-artifacts] Fix end to end development. Thanks to @fearthecowboy for help on this one. I considered ripping out the rush dependency, since it seems like we are only ever going to have one meaningful "project", and the dependency deduplication we need seems to be already done by pnpm (rather than npm), but after talking with @fearthecowboy I've decided to not go there since we still have rush linking the test project in. Unfortunately, there does not appear to be an effiicent way to build the typescript parts out-of-source, since they depend on node_modules which is put into the source tree. This adds a vcpkg.ps1 which does the same "environment hacking" as the in-development ce.ps1, teaches CMakeLists.txt to invoke rush and the typescript compiler as necessary, and teaches vcpkg.exe to use a hard-coded-into-the-binary path to the source tree when that in-development setting is turned on. The previous "always download latest ce bits" behavior is retained for folks who build vcpkg.exe from source and don't want to arrange for node and rush to be available. * format * Add better messages during build. * Update vcpkg-scripts-sha to include python3_with_venv * Restore espidf handling backed out in 323242c . * Fix python fetch in another place. * Update espressif support * Updated epressif support to do better git clone and properly handle registry zip files * Undo accidential CMakeLists.txt changes broken by merge. * Fix removal instructions for PowerShell (#603) * Update ce/ce/installers/espidf.ts Co-authored-by: Billy O'Neal <bion@microsoft.com> * Update ce/ce/archivers/git.ts Co-authored-by: Billy O'Neal <bion@microsoft.com> * Update ce/ce/archivers/git.ts Co-authored-by: Billy O'Neal <bion@microsoft.com> * Update ce/ce/archivers/git.ts Co-authored-by: Billy O'Neal <bion@microsoft.com> * add strip=-1 option to tar to allow detection of how many folders to strip * simplify heartbeat during git * added comment with reasoning behind git clone changes Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com> Co-authored-by: Ben McMorran <ben.mcmorran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the instructions as-is fails because of junction points.