Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD support #607

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Add FreeBSD support #607

merged 1 commit into from
Jun 28, 2022

Conversation

bsiegert
Copy link
Contributor

Treat FreeBSD like macOS (which is accurate in terms of development!) in the code to determine the MAC address of a network interface.

With this change, vcpkg-tool compiles fine on FreeBSD 13. The test suite passes.

Treat FreeBSD like macOS (which is accurate in terms of development!)
in the code to determine the MAC address of a network interface.

With this change, vcpkg-tool compiles fine on FreeBSD 13. The test
suite passes.
@bsiegert bsiegert mentioned this pull request Jun 28, 2022
@BillyONeal
Copy link
Member

Notwithstanding what I said in #359 , I think this is OK because it isn't something:

  • that we are likely to regress
  • that indicates the underlying implementation is broken for reasons we don't understand
  • where another hypothetical implementation may require the opposite resolution

Thanks for your contribution!

@BillyONeal BillyONeal merged commit cc854b3 into microsoft:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants