Localization redesign #615
Conversation
- Sorted Declared/Registered messages in alphabetical order.
Removed HelpTableFormat message. The HelpTableFormatter needs to be updated to require LocalizedString as input. I intend to do this work in a separate PR.
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
…to messages.h/cpp
…, and vcpkg.cpp to messages.h/cpp
…s.cpp, checks.cpp, and downloads.cpp to messages.h/cpp
….cpp, cmakevars.cpp, commands.ci.cpp, install.cpp, packagespec.cpp, portfileprovider.cpp, registries.cpp, tools.cpp, and main.cpp to messages.h/cpp
…tool into localization_redesign # Conflicts: # src/vcpkg/archives.cpp # src/vcpkg/binarycaching.cpp
JavierMatosD
requested review from
vicroms,
BillyONeal and
ras0219-msft
and removed request for
vicroms
There was a problem hiding this comment.
In addition to comments, I think you should delete DECLARE_AND_REGISTER_MESSAGE since nobody should be using it after this redesign.
I also think it would make sense to move more stuff out of the header now that we're doing everything in the one source file but that should be a separate PR if at all.
I was planning on cleaning up the header in a separate PR. I want to make sure that removing the excess stuff doesn't break something else. |
JavierMatosD
force-pushed
the
localization_redesign
branch
from
fd72cf5
to
8e37e65
Compare
- Fuzz help messages need to be unlocalized. This change will occur in another print - Moved localized messages from messages.h/cpp to main.cpp - Messages need to be unlocalized.
|
A downside is that you now constantly get merge conflicts and have to rebuild everything if you switch a branch :/ |
This PR consolidates all localized messages into two files. All message declarations are declared in messages.h and registered in messages.cpp. All the messages are sorted alphabetically. These changes will allow contributors to find messages quickly and reuse them if possible without cluttering the source files.