Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization nitpicks. #628

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

BillyONeal
Copy link
Member

These are minor nitpick fixes observed after doing a full build for this week's release here: https://dev.azure.com/vcpkg/public/_build/results?buildId=75028&view=logs&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&t=da63cf11-1f12-503b-6d64-3b2fb713c172

Note the new / extra single quotes in:

Uploaded binaries to '1' 'HTTP remotes'.

Changes:

  • Removed the extra 's from UploadedBinaries
  • Checked for other 's in messages and removed a few more where they didn't add anything
  • Moved FuzzExpectedOneOf to the fuzz tester only
  • Changed FailedToStoreBinaryCache to append the message internally on the next line
  • Spell checked a few message names

These are minor nitpick fixes observed after doing a full build for this week's release here: https://dev.azure.com/vcpkg/public/_build/results?buildId=75028&view=logs&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&t=da63cf11-1f12-503b-6d64-3b2fb713c172

Note the new / extra single quotes in:

Uploaded binaries to '1' 'HTTP remotes'.

Changes:
* Removed the extra 's from UploadedBinaries
* Checked for other 's in messages and removed a few more where they didn't add anything
* Moved FuzzExpectedOneOf to the fuzz tester only
* Changed FailedToStoreBinaryCache to append the message internally on the next line
* Spell checked a few message names
@BillyONeal BillyONeal merged commit fb7e3b1 into microsoft:main Jul 13, 2022
@BillyONeal BillyONeal deleted the single-quotes branch July 13, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants