-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize binaryparagraph.cpp and sourceparagraph.cpp #631
Localize binaryparagraph.cpp and sourceparagraph.cpp #631
Conversation
# Conflicts: # locales/messages.en.json # locales/messages.json
Parameterize InvalidLinkage to take a system_name to enable re-usability.
Issue: re-use replacement variables
Issue: re-use of replacement variables
…t should be options
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Co-authored-by: Billy O'Neal <bion@microsoft.com>
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
…pp_and_sourceparagraph.cpp # Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
…aragraph.cpp # Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
@@ -1616,11 +1613,12 @@ namespace vcpkg | |||
auto maybe_configuration = reader.visit(*configuration, get_configuration_deserializer()); | |||
if (!reader.errors().empty()) | |||
{ | |||
print2(Color::error, "Errors occurred while parsing ", ManifestDeserializer::VCPKG_CONFIGURATION, "\n"); | |||
msg::println_error(msgErrorWhileParsing, msg::path = ManifestDeserializer::VCPKG_CONFIGURATION); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong, it should be listing the actual file on each line with an error, but it faithfully preserves the previous behavior. It does add "error: " in front of everything but I think that's OK. (Here's the old behavior:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
)", | ||
parsed_paragraph.error(), | ||
my_paragraph); | ||
Checks::msg_exit_maybe_upgrade( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[sanity check]
makes it sound like a debugging message, but it clearly has user instructions, so it makes sense.
That said, it seems like line 293 should get the same treatment?
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Localizing: