switch to host triplet as the default. #640

Neumann-A · 2022-07-19T20:26:19Z

https://twitter.com/augustin_popa/status/1549127848140480512 ....

(ready to be merged in september 2023 ;) )

BillyONeal · 2022-07-25T18:09:33Z

As I said back in #614 (and elsewhere), this is a change we can't make lightly because it breaks existing scripts (and our 'no changes means no changes' mantra).

We have discussed doing this before back when VS2022 changed the default for new projects, and said that in order to do it we need:

A period of time (~6 months) before we make the change where we warn that we are going to make the change and how to fix it. (Add --triplet or qualify all references with :triplet)
A period of time (~6 months) after we make the change where we warn that the behavior changed.

Neumann-A · 2022-07-25T19:12:06Z

Don't you have telemetry how many people actually still build x86 outside manifest mode?

Most people probably already have VCPKG_DEFAULT_TRIPLET set because of the default vcpkg has and will never observe the change any way ;)
Furthermore it is more surprising that the default host triplet is x64-windows while the target is x86-windows.

Just make a big blog post with the release that the default triplet switched and add an extra message to bootstrap that the triplet has switched.... I really don't see a reason to give any grace period at all. New users have the problem to adapt. Old users probably don't care that much and know what they need to do.

autoantwort · 2023-02-16T12:52:25Z

I think you can close this now because of #881

Neumann-A · 2023-02-25T19:38:24Z

I think you can close this now because of #881

Just prints the warning does not do the change. But according to the warning something more sophisticated will be implemented? I'll keep this open until that more sophisticated stuff is actually implemented ;)

BillyONeal · 2023-02-27T07:18:01Z

Just prints the warning does not do the change. But according to the warning something more sophisticated will be implemented? I'll keep this open until that more sophisticated stuff is actually implemented ;)

It isn't any more sophisticated; it's just that the clock is now running on giving people reasonable warning that the change is happening.

Neumann-A · 2023-02-27T09:16:27Z

It isn't any more sophisticated;

Ok the message gives the impression that at least the correct host default would be used, e.g. on arm64 it should be arm64-windows and not x64-windows. Maybe this can be changed to simply call the function for the default host-triplet instead?

E.g. removing the #ifdef and call default_host_triplet(args) instead of system_triplet()

BillyONeal · 2023-02-27T09:26:46Z

Ah, maybe. I kinda forget arm64-windows exists 😅

src/vcpkg/build.cpp

# Conflicts: # include/vcpkg/triplet.h # src/vcpkg/commands.build.cpp # src/vcpkg/commands.check-support.cpp # src/vcpkg/commands.ci.cpp # src/vcpkg/commands.dependinfo.cpp # src/vcpkg/commands.export.cpp # src/vcpkg/commands.install.cpp # src/vcpkg/commands.remove.cpp # src/vcpkg/commands.set-installed.cpp # src/vcpkg/commands.upgrade.cpp # src/vcpkg/triplet.cpp

Neumann-A · 2023-08-23T08:09:49Z

Don't know what to do about:

  D:\a\vcpkg-tool\vcpkg-tool\out\build\windows-ci\vcpkg.ps1 --x-buildtrees-root=D:\a\vcpkg-tool\vcpkg-tool\out\build\windows-ci\work\testing\buildtrees --x-install-root=D:\a\vcpkg-tool\vcpkg-tool\out\build\windows-ci\work\testing\installed --x-packages-root=D:\a\vcpkg-tool\vcpkg-tool\out\build\windows-ci\work\testing\packages --overlay-ports=D:\a\vcpkg-tool\vcpkg-tool\azure-pipelines/e2e-ports/overlays --overlay-triplets=D:\a\vcpkg-tool\vcpkg-tool\azure-pipelines/e2e-ports/triplets depend-info vcpkg-hello-world-1
  vcpkg-cmake: 
  vcpkg-cmake-config: 
  vcpkg-hello-world-1: vcpkg-cmake, vcpkg-cmake-config
  
  Exception: D:\a\vcpkg-tool\vcpkg-tool\azure-pipelines\end-to-end-tests-dir\cli.ps1:24
  Line |
    24 |          throw 'depend-info with unqualified spec should emit the trip …
       |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       | depend-info with unqualified spec should emit the triplet warning

@BillyONeal: I tested with an official release and it also doesn't print the triplet with depend-info.
See:

neumann@heineken MINGW64 /e/vcpkg_folders/master_clean (update_zlib)
$ ./bootstrap-vcpkg.sh
Downloading https://github.com/microsoft/vcpkg-tool/releases/download/2023-08-09/vcpkg.exe -> E:\vcpkg_folders\master_clean\vcpkg.exe... done.
Validating signature... done.

vcpkg package management program version 2023-08-09-9990a4c9026811a312cb2af78bf77f3d9d288416

See LICENSE.txt for license information.

neumann@heineken MINGW64 /e/vcpkg_folders/master_clean (update_zlib)
$ ./vcpkg.exe depend-info zlib
vcpkg-cmake:
zlib: vcpkg-cmake

Neumann-A · 2023-08-23T08:13:42Z

Ok figured out why. I had VCPKG_DEFAULT(_HOST)?_TRIPLET set in the environment.
But this:

E:\vcpkg_folders\master_clean>vcpkg.exe depend-info zlib
warning: Starting with the September 2023 release, the default triplet for vcpkg libraries will change from x86-windows to the detected host triplet (x64-windows). To resolve this message, add --triplet x86-windows to keep the same behavior.
vcpkg-cmake:
zlib: vcpkg-cmake

is probably not what the test wanted to have or is it? (I currently assume that the test is generally broken an did not want to detect the warning)

Neumann-A · 2023-08-23T08:19:08Z

src/vcpkg/commands.export.cpp

@@ -438,11 +438,6 @@ namespace vcpkg::Export
                return parse_package_spec(
                    arg, default_triplet, default_triplet_used, COMMAND_STRUCTURE.get_example_text());


Should the usage of
default_triplet, default_triplet_used
generally be removed?
I kind of let them in since removing then would create a large changeset.

Neumann-A · 2023-08-23T08:21:52Z

Ah okay i misread I thought the idea was to emit the triplet for host deps or something in depend-info but actually the tests tells me that it is about warning itself.

# Conflicts: # src/vcpkg/commands.build.cpp # src/vcpkg/commands.ci.cpp

This removes the 'in September 2023' message and does what the message said we would do. For the next 6 months we'll warn that the behavior changed. The specific change to triplet.cpp to change the triplet setting is from microsoft#640 Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>

#1180) This removes the 'in September 2023' message and does what the message said we would do. For the next 6 months we'll warn that the behavior changed. The specific change to triplet.cpp to change the triplet setting is from #640 Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>

switch to x64 as the default

b1cd4f6

autoantwort mentioned this pull request Dec 24, 2022

cmake find_package cannot find boost microsoft/vcpkg#28508

Closed

Neumann-A and others added 3 commits March 9, 2023 21:34

Merge branch 'microsoft:main' into default_to_x64

25906e3

use host triplet

85cbe7b

remove default triplet warning

b62e8a1

Neumann-A changed the title ~~switch to x64-windows as the default~~ switch to host triplet as the default. Mar 9, 2023

Merge branch 'main' into default_to_x64

bd7950b

Neumann-A commented Apr 19, 2023

View reviewed changes

src/vcpkg/build.cpp Outdated Show resolved Hide resolved

Neumann-A marked this pull request as draft April 19, 2023 10:34

Neumann-A added 3 commits August 23, 2023 09:32

apply format diff

4fb1fec

add database check

9302e44

Neumann-A commented Aug 23, 2023

View reviewed changes

remove pipeline testing for the warning message.

eb10025

Neumann-A marked this pull request as ready for review August 23, 2023 09:18

Merge remote-tracking branch 'upstream/main' into default_to_x64

8e21114

# Conflicts: # src/vcpkg/commands.build.cpp # src/vcpkg/commands.ci.cpp

BillyONeal mentioned this pull request Sep 5, 2023

Change the default triplet to the same as the host triplet on Windows. #1180

Merged

Neumann-A closed this Sep 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch to host triplet as the default. #640

switch to host triplet as the default. #640

Neumann-A commented Jul 19, 2022 •

edited

Loading

BillyONeal commented Jul 25, 2022

Neumann-A commented Jul 25, 2022

autoantwort commented Feb 16, 2023

Neumann-A commented Feb 25, 2023

BillyONeal commented Feb 27, 2023

Neumann-A commented Feb 27, 2023

BillyONeal commented Feb 27, 2023

Neumann-A commented Aug 23, 2023 •

edited

Loading

Neumann-A commented Aug 23, 2023 •

edited

Loading

Neumann-A Aug 23, 2023

Neumann-A commented Aug 23, 2023

		@@ -438,11 +438,6 @@ namespace vcpkg::Export
		return parse_package_spec(
		arg, default_triplet, default_triplet_used, COMMAND_STRUCTURE.get_example_text());

switch to host triplet as the default. #640

switch to host triplet as the default. #640

Conversation

Neumann-A commented Jul 19, 2022 • edited Loading

BillyONeal commented Jul 25, 2022

Neumann-A commented Jul 25, 2022

autoantwort commented Feb 16, 2023

Neumann-A commented Feb 25, 2023

BillyONeal commented Feb 27, 2023

Neumann-A commented Feb 27, 2023

BillyONeal commented Feb 27, 2023

Neumann-A commented Aug 23, 2023 • edited Loading

Neumann-A commented Aug 23, 2023 • edited Loading

Neumann-A Aug 23, 2023

Choose a reason for hiding this comment

Neumann-A commented Aug 23, 2023

Neumann-A commented Jul 19, 2022 •

edited

Loading

Neumann-A commented Aug 23, 2023 •

edited

Loading

Neumann-A commented Aug 23, 2023 •

edited

Loading