[Localization] Aries #680
Merged
[Localization] Aries #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
Thomas1664
reviewed
Sep 12, 2022
|
Thanks for the review @Thomas1664 :) |
BillyONeal
requested changes
Sep 26, 2022
There was a problem hiding this comment.
I think we need an answer on what --prefab-debug is doing before we land this.
I would really like to see the consistent "creating {path}" treatment done here as even this one command isn't consistent about where it puts and does not put paths, but I would understand if you were like "Bill, this is just trying to localize what we have, not trying to fix the world"
The other comments aren't over my dead body issues.
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
included <vcpkg/base/system.debug.h> rerouted all localized messages related to --prefab-debug option to be gaurded by --debug instead
vicroms
reviewed
Oct 12, 2022
* Removed MissingNDKVersion message * Moved exit_filesystem_call_error to vcpkg namespace
vicroms
approved these changes
Oct 17, 2022
BillyONeal
approved these changes
Oct 18, 2022
BillyONeal
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR localizes messages in the following files: