Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command x-history #689

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

Thomas1664
Copy link
Contributor

@ras0219-msft ras0219-msft merged commit 3bb69a7 into microsoft:main Sep 7, 2022
@ras0219-msft
Copy link
Contributor

Thanks!

@Thomas1664 Thomas1664 deleted the remove-xhistory branch September 7, 2022 21:52
@JackBoosY
Copy link
Contributor

This will lead to a serious problem: how can the user set the builtin-baseline by querying the commit id corresponding to the version of the port?

@Neumann-A
Copy link
Contributor

This will lead to a serious problem: how can the user set the builtin-baseline by querying the commit id corresponding to the version of the port?

Just look up the ID in the version history versions/<port-first-char>-/<portname>.json ?

@JackBoosY
Copy link
Contributor

This will lead to a serious problem: how can the user set the builtin-baseline by querying the commit id corresponding to the version of the port?

Just look up the ID in the version history versions/<port-first-char>-/<portname>.json ?

I don't think users want to flip through the version history instead of using a command to get this value.
For non-manifest mode, users also encounter this problem.

@dg0yt
Copy link
Contributor

dg0yt commented Oct 19, 2022

This will lead to a serious problem: how can the user set the builtin-baseline by querying the commit id corresponding to the version of the port?

Just look up the ID in the version history versions/<port-first-char>-/<portname>.json ?

The commit ID is not in the file. To get this ID, you need git blame versions/<port-first-char>-/<portname>.json.

@BillyONeal
Copy link
Member

@JackBoosY ,

@vicroms @ras0219-msft @valeriaconde @JavierMatosD @markle11m and I discussed this today at our PR review meeting, with the following observations:

  • This command existed only to prepopulate the version database, and would have been a z- command had that convention existed at the time.
  • We don't believe that the right approach is for someone to set a baseline by looking for particular port versions. In particular, there are lots of versions that are available from before when baselines existed.
  • Even if this exists, we believe only major "groups" of ports are practical use cases here, like boost or qt. There may be correct ways to make this work, like explicitly documenting when we changed these, but that doesn't justify keeping this git based implementation.
  • If we get concrete customer use cases that need this, we can bring it back, but we need that concrete customer use case.

@MonicaLiu0311
Copy link

@BillyONeal
Here is a concrete customer use case, please pay attention: microsoft/vcpkg#27451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants