[Localization] Cepheus #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas1664
reviewed
Sep 24, 2022
BillyONeal
requested changes
Oct 5, 2022
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp # src/vcpkg/portfileprovider.cpp
* CouldNotFindLinkerMember * CouldNotFindSecondLinkerMember * SecongLinkerMemberTooSmallArchiveMem * CouldNotFindLinkerMember
BillyONeal
approved these changes
Oct 19, 2022
include/vcpkg/base/messages.h
Outdated
Comment on lines
783
to
794
| DECLARE_MESSAGE(FailedToFetchError, | ||
| (msg::error_msg, msg::package_name, msg::error), | ||
| "{error} is the error code", | ||
| "{error_msg}\nFailed to fetch {package_name}:\n{error}"); | ||
| DECLARE_MESSAGE(CouldNotFindBaselineInCommit, | ||
| (msg::value, msg::package_name, msg::error_msg), | ||
| "{value} is a commit sha.", | ||
| "Couldn't find baseline in commit `\"{value}\"` from repo {package_name}:\n{error_msg}"); | ||
| DECLARE_MESSAGE(CouldNotFindGitTreeAtCommit, | ||
| (msg::package_name, msg::value, msg::error_msg), | ||
| "{value} is a commit sha", | ||
| "could not find the git tree for `versions` in repo {package_name} at commit {value}: {error_msg}"); |
There was a problem hiding this comment.
I think these error_msgs should probably be printed on their own rather than being included in the localized part.
include/vcpkg/base/messages.h
Outdated
Comment on lines
1047
to
1051
| "Fetching baseline information from {package_name}..."); | ||
| DECLARE_MESSAGE(FetchingRegistryInfo, | ||
| (msg::package_name, msg::value), | ||
| "{value} is a reference", | ||
| "Fetching registry information from {package_name} ({value})..."); |
There was a problem hiding this comment.
Ditto I think package_name is actually a URI?
Also, what is "a reference"?
added 'commit_sha" as a new argument removed a leading white space etc
autoantwort
reviewed
Dec 18, 2022
Comment on lines
+127
to
+132
| if (memcmp(first_linker_member_header.name, "/ ", 2) != 0) | ||
| { | ||
| Debug::println("Could not find proper first linker member"); | ||
| Checks::exit_fail(VCPKG_LINE_INFO); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why? Now vcpkg simply exists without any error message. For example:
...
-- Installing x64-mingw-static-rel
-- Fixing pkgconfig file: G:/vcpkg4/packages/jemalloc_x64-mingw-static/lib/pkgconfig/jemalloc.pc
-- Fixing pkgconfig file: G:/vcpkg4/packages/jemalloc_x64-mingw-static/debug/lib/pkgconfig/jemalloc.pc
-- Installing: G:/vcpkg4/packages/jemalloc_x64-mingw-static/share/jemalloc/copyright
-- Performing post-build validation
admin@DESKTOP-NDEQJD0 MSYS /g/vcpkg4 (master)
$
Instead of showing an error message like before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR localizes messages in the following files: