Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Libra #724

Merged
merged 15 commits into from
Oct 27, 2022
Merged

Conversation

JavierMatosD
Copy link
Contributor

Localizes messages in the following files:

  • vcpkglib.cpp
  • vcpkgpaths.cpp
  • update.cpp
  • tools.cpp

@JavierMatosD JavierMatosD marked this pull request as ready for review October 5, 2022 00:03
# Conflicts:
#	include/vcpkg/base/messages.h
#	locales/messages.en.json
#	locales/messages.json
#	src/vcpkg/base/messages.cpp
# Conflicts:
#	include/vcpkg/base/messages.h
#	locales/messages.en.json
#	locales/messages.json
#	src/vcpkg/base/messages.cpp
* consolidate messages related to parsing and missing top-level object
* removed messages that were redundant
Comment on lines 714 to 715
msg::println_error(msgExpectedPathToExist, msg::path = exe_path);
Checks::exit_fail(VCPKG_LINE_INFO);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg::println_error(msgExpectedPathToExist, msg::path = exe_path);
Checks::exit_fail(VCPKG_LINE_INFO);
Checks::msg_exit_with_error(VCPKG_LINE_INFO, msgExpectedPathToExist, msg::path = exe_path);

I think?

Comment on lines 260 to 263
msg::println_error(msg::format(msgInvalidBundleDefinition)
.append_raw('\n')
.append_raw(maybe_bundle_doc.error()->to_string()));
Checks::exit_fail(VCPKG_LINE_INFO);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg::println_error(msg::format(msgInvalidBundleDefinition)
.append_raw('\n')
.append_raw(maybe_bundle_doc.error()->to_string()));
Checks::exit_fail(VCPKG_LINE_INFO);
Checks::msg_exit_with_error(VCPKG_LINE_INFO, msg::format(msgInvalidBundleDefinition)
.append_raw('\n')
.append_raw(maybe_bundle_doc.error()->to_string()));

? I'm not sure on this one.

@BillyONeal BillyONeal merged commit e834bc7 into microsoft:main Oct 27, 2022
@JavierMatosD JavierMatosD deleted the Localization_Libra branch April 20, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants