-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] Libra #724
Merged
Merged
[Localization] Libra #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4653a3a
to
3572a99
Compare
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
BillyONeal
previously requested changes
Oct 5, 2022
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
* consolidate messages related to parsing and missing top-level object * removed messages that were redundant
BillyONeal
approved these changes
Oct 26, 2022
src/vcpkg/tools.cpp
Outdated
Comment on lines
714
to
715
msg::println_error(msgExpectedPathToExist, msg::path = exe_path); | ||
Checks::exit_fail(VCPKG_LINE_INFO); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
msg::println_error(msgExpectedPathToExist, msg::path = exe_path); | |
Checks::exit_fail(VCPKG_LINE_INFO); | |
Checks::msg_exit_with_error(VCPKG_LINE_INFO, msgExpectedPathToExist, msg::path = exe_path); |
I think?
src/vcpkg/vcpkgpaths.cpp
Outdated
Comment on lines
260
to
263
msg::println_error(msg::format(msgInvalidBundleDefinition) | ||
.append_raw('\n') | ||
.append_raw(maybe_bundle_doc.error()->to_string())); | ||
Checks::exit_fail(VCPKG_LINE_INFO); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
msg::println_error(msg::format(msgInvalidBundleDefinition) | |
.append_raw('\n') | |
.append_raw(maybe_bundle_doc.error()->to_string())); | |
Checks::exit_fail(VCPKG_LINE_INFO); | |
Checks::msg_exit_with_error(VCPKG_LINE_INFO, msg::format(msgInvalidBundleDefinition) | |
.append_raw('\n') | |
.append_raw(maybe_bundle_doc.error()->to_string())); |
? I'm not sure on this one.
BillyONeal
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localizes messages in the following files: