[versioning] Add message when vcpkg is cloned to a shallow repository #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas1664
reviewed
Oct 9, 2022
|
If not done: We should also check if VCPKG_ROOT is a git repo at all. Some users download the repo instead of clone it. |
Thomas1664
reviewed
Oct 9, 2022
vicroms
force-pushed
the
detect_shallow_clones
branch
from
5539edc
to
3aec1d0
Compare
BillyONeal
requested changes
Oct 10, 2022
I think we should get rid of the "failed to tar port directory" part of this message since that's already implied by the message? |
Co-authored-by: Billy O'Neal <bion@microsoft.com>
vicroms
changed the title
BillyONeal
approved these changes
Oct 11, 2022
|
Output cleanup will be made in a separate PR since it will conflict with ongoing localization efforts by Javier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appends an additional error message when a built-in repository error occurs and vcpkg is cloned into a shallow repository.
Rough implementation.
Improvements to how we handle versioning errors can be made but I believe is better to wait until #556 is merged to make more extensive changes.
On baseline not in git history:
On version not in git history:
