Treat * as 'no filter' when searching a registry for versions. #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…particular registry. Before: ``` PS C:\Dev\test> ..\vcpkg\vcpkg.exe find artifact gcc warning: vcpkg-artifacts are experimental and may change at any time. Downloading vcpkg-ce bundle 2022-10-17... Artifact Version Summary microsoft:compilers/arm/gcc 2020.10.0 GCC compiler for ARM CPUs. arm:gcc 10.3.0-2021.10 GCC compiler for ARM CPUs. PS C:\Dev\test> ..\vcpkg\vcpkg.exe find artifact arm:gcc warning: vcpkg-artifacts are experimental and may change at any time. Artifact Version Summary arm:gcc 10.3.0-2021.10 GCC compiler for ARM CPUs. PS C:\Dev\test> ..\vcpkg\vcpkg.exe add artifact arm:gcc warning: vcpkg-artifacts are experimental and may change at any time. ERROR: Unable to resolve artifact: arm:gcc PS C:\Dev\test> ``` After: ``` PS C:\Dev\test> C:\Dev\vcpkg-tool\out\build\x64-Debug\vcpkg.ps1 find artifact gcc warning: vcpkg-artifacts are experimental and may change at any time. Using in-development vcpkg-artifacts built at: C:/Dev/vcpkg-tool/ce/ce Artifact Version Summary microsoft:compilers/arm/gcc 2020.10.0 GCC compiler for ARM CPUs. arm:gcc 10.3.0-2021.10 GCC compiler for ARM CPUs. PS C:\Dev\test> C:\Dev\vcpkg-tool\out\build\x64-Debug\vcpkg.ps1 find artifact arm:gcc warning: vcpkg-artifacts are experimental and may change at any time. Using in-development vcpkg-artifacts built at: C:/Dev/vcpkg-tool/ce/ce Artifact Version Summary arm:gcc 10.3.0-2021.10 GCC compiler for ARM CPUs. PS C:\Dev\test> C:\Dev\vcpkg-tool\out\build\x64-Debug\vcpkg.ps1 add artifact arm:gcc warning: vcpkg-artifacts are experimental and may change at any time. Using in-development vcpkg-artifacts built at: C:/Dev/vcpkg-tool/ce/ce Artifact Version Status Dependency Summary arm:gcc 10.3.0-2021.10 will install GCC compiler for ARM CPUs. Run `vcpkg activate` to apply to the current terminal PS C:\Dev\test> ```
JavierMatosD
approved these changes
Oct 26, 2022
ras0219-msft
approved these changes
Oct 28, 2022
markle11m
approved these changes
Oct 28, 2022
|
Mark told me this looks good to him over chat, so merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes being unable to add / use / etc. artifacts filtered for a particular registry.
Before:
After: