Documenting our use of VSLANG #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicroms
previously requested changes
Oct 26, 2022
|
Should we point out that the Visual Studio setting may override VSLANG from the user's environment? Has that been tested? |
BillyONeal
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Should we point out that the Visual Studio setting may override VSLANG from the user's environment? Has that been tested?
This is vcpkg-team-facing not end-user-facing documentation. We certainly are not suggesting that users set anything like that. I'm not sure why we would be testing entirely-internal-to-VS behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for how to change the language in vcpkg ( i.e., documenting our use of the VSLANG environment variable).