Localization hookup artifacts #773
Conversation
…rtifacts # Conflicts: # ce/common/config/rush/pnpm-lock.yaml
# Conflicts: # ce/common/config/rush/pnpm-lock.yaml
| add_custom_target(generate-message-map | ||
| COMMAND vcpkg x-generate-default-message-map locales/messages.json ${CMAKE_CURRENT_LIST_DIR}/ce/ce/locales/messages.json | ||
| DEPENDS ${CMAKE_CURRENT_LIST_DIR}/ce/ce/locales/messages.json | ||
| WORKING_DIRECTORY ${CMAKE_CURRENT_LIST_DIR} | ||
| COMMENT "Update locales/messages.json" | ||
| VERBATIM | ||
| ) |
There was a problem hiding this comment.
Huh why is this behind VCPKG_ARTIFACTS_DEVELOPMENT?
There was a problem hiding this comment.
You still need the old version when you do "normal" vcpkg-tool development
There was a problem hiding this comment.
Huh why is this behind
VCPKG_ARTIFACTS_DEVELOPMENT?
Because VCPKG_ARTIFACTS_DEVELOPMENT implies that you have node / NPM / rush et al. set up and working on your machine. People deploying vcpkg on a platform we don't have a binary release for can't / shouldn't be expected to provide those dependencies.
There was a problem hiding this comment.
Yeah but only executing the command vcpkg x-generate-default-message-map locales/messages.json is needed for vcpkg-tool development to make the ci happy. So that should be added as target if VCPKG_ARTIFACTS_DEVELOPMENT is false.
There was a problem hiding this comment.
Yeah but only executing the command
vcpkg x-generate-default-message-map locales/messages.jsonis needed for vcpkg-tool development to make the ci happy.
That command needs VCPKG_ARTIFACTS_DEVELOPMENT to be on after this change.
No description provided.