Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special case language 1033 to use the default messages rather than an "en" json file. #776

Merged
merged 8 commits into from
Oct 31, 2022
Merged

Special case language 1033 to use the default messages rather than an "en" json file. #776

merged 8 commits into from
Oct 31, 2022

Conversation

BillyONeal
Copy link
Member

  • This ensures that local development can edit the messages without creating a catch-22 where the messages must be updated with x-generate-message-map because they're built into the tool, but running x-generate-message-map requires building the tool .......
  • This saves the space of the en json file.

@BillyONeal BillyONeal merged commit c539cc1 into microsoft:main Oct 31, 2022
@BillyONeal BillyONeal deleted the development-messages branch October 31, 2022 20:07
@BillyONeal
Copy link
Member Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JavierMatosD JavierMatosD JavierMatosD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyONeal @JavierMatosD