Unbreak fmt upgrades #783
Unbreak fmt upgrades #783
Conversation
|
To clarify, we have 1 scenario ever for this which is that a signed build needs to be able to parachute in a different URI on the command line because there are restrictions on what servers signed builds are allowed to talk to. For example: vcpkg-tool/azure-pipelines/signing.yml Line 203 in 427f063 Can this be done more reasonably without making it a cache variable in the first place? This seems to be constantly breaking folks, however little I care about saying "just delete cache and reconfigure" |
| if("$CACHE{VCPKG_FMT_URL}" MATCHES "^https://github.com/fmtlib/fmt/archive/refs/tags") | ||
| unset(VCPKG_FMT_URL CACHE) # Fix upgrade | ||
| endif() | ||
| if(NOT VCPKG_FMT_URL) |
There was a problem hiding this comment.
If you pass the variable from outside, it is used and not overriden...
| @@ -4,7 +4,13 @@ option(VCPKG_DEPENDENCY_EXTERNAL_FMT "Use an external version of the fmt library | |||
| # builds which have restricted internet access; see azure-pipelines/signing.yml | |||
| # Note that the SHA512 is the same, so vcpkg-tool contributors need not be concerned that we built | |||
| # with different content. | |||
| set(VCPKG_FMT_URL "https://github.com/fmtlib/fmt/archive/refs/tags/9.1.0.tar.gz" CACHE STRING "URL to the fmt release tarball to use.") | |||
| # A cache variable cannot be used it here because it will break contributors' builds on fmt update. | |||
| if("$CACHE{VCPKG_FMT_URL}" MATCHES "^https://github.com/fmtlib/fmt/archive/refs/tags") | |||
There was a problem hiding this comment.
...unless it is assumed to be an old default value: This cache value must be removed in order to fix upgrades.
|
Thanks :) |
VCPKG_FMT_URLmust not be cached because it the cached value breaks contributors whenfmtand its SHA512 sum is updated.