Turn on CodeQL and fix BinSkim regressions

[BillyONeal]

No description provided.

[Neumann-A]

How about using CMake presets instead and be a good example how CMake should be done ?

[ras0219-msft]

In general, we should either:

1. add_compile_options() / add_link_options()
2. Move these to a Toolchain file

Modifying CMAKE_C(XX)_FLAGS in the CMakeLists.txt is always a smell. That said, this works and follows what came before, so not requiring changes at this time.

[BillyONeal]

How about using CMake presets instead and be a good example how CMake should be done ?
[...]
In general, we should either:

1. add_compile_options() / add_link_options()
2. Move these to a Toolchain file

Modifying CMAKE_C(XX)_FLAGS in the CMakeLists.txt is always a smell. That said, this works and follows what came before, so not requiring changes at this time.

This is a controversial opinion among the vcpkg maintainers, but I still believe that CMake expecting application authors to separate warnings manipulation into separate files is unreasonable. And I cite as evidence that I've reviewed a lot of things that are shipped into vcpkg ports and never ever seen a project do it. Separate files is a statement that separate people are interested in the values, and that isn't true for diagnostics.

Contrast with /machine: switches in similar that make sense to be part of the "toolchain".

[Neumann-A]

And I cite as evidence that I've reviewed a lot of things that are shipped into vcpkg ports and never ever seen a project do it.

Most ports predate presets and most projects don't care about proper CMake ;)
VTK/Qt in general give an option to opt out of the flag setting business.

[BillyONeal]

VTK/Qt in general give an option to opt out of the flag setting business.

And so do we. VCPKG_DEVELOPMENT_WARNINGS defaults to off.

[Neumann-A]

And so do we. VCPKG_DEVELOPMENT_WARNINGS defaults to off.

That is just the warning flag setting business and leaves at least:

vcpkg-tool/CMakeLists.txt

Lines 120 to 130 in 5fdee72

	string(APPEND CMAKE_C_FLAGS " -FC -permissive- -utf-8 /guard:cf")
	string(APPEND CMAKE_CXX_FLAGS " /EHsc -FC -permissive- -utf-8 /guard:cf")
	string(APPEND CMAKE_C_FLAGS_RELEASE " /Zi")
	string(APPEND CMAKE_CXX_FLAGS_RELEASE " /Zi")
	string(APPEND CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO " /DEBUG /INCREMENTAL:NO /debugtype:cv,fixup /guard:cf")
	string(APPEND CMAKE_EXE_LINKER_FLAGS_RELEASE " /DEBUG /INCREMENTAL:NO /debugtype:cv,fixup /guard:cf")
	if (MSVC_CXX_ARCHITECTURE_ID STREQUAL "x64")
	string(APPEND CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO " /CETCOMPAT")
	string(APPEND CMAKE_EXE_LINKER_FLAGS_RELEASE " /CETCOMPAT")
	endif()