Fix several release compliance problems. #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BillyONeal
commented
Nov 24, 2022
BillyONeal
commented
- Get all secrets from the same place rather than several library entries.
- Plumb cmakerc into artemis.
- Add .npmrc files pointing to https://dev.azure.com/vcpkg/public/_artifacts/feed/vcpkg-ecmascript-dependencies/ as requested by Central Feed Services.
- Tell CodeQL what languages we use.
- Delete unused ce.ps1 file.
* Get all secrets from the same place rather than several library entries. * Plumb cmakerc into artemis. * Add .npmrc files pointing to https://dev.azure.com/vcpkg/public/_artifacts/feed/vcpkg-ecmascript-dependencies/ as requested by Central Feed Services. * Tell CodeQL what languages we use. * Delete unused ce.ps1 file.
ras0219-msft
approved these changes
Nov 29, 2022
| @@ -85,14 +85,14 @@ dependencies: | |||
| packages: | |||
|
|
|||
| /@azure/abort-controller/1.1.0: | |||
| resolution: {integrity: sha512-TrRLIoSQVzfAJX9H1JeFjzAoDGcoK1IYX1UImfceTZpsyYfWr09Ss1aHW1y5TrrR3iq6RZLBwJ3E24uwPhwahw==} | |||
| resolution: {integrity: sha1-eI7nhFelWvihrTQqyxgjg9IRkkk=} | |||
There was a problem hiding this comment.
Is this use of SHA1 against policy?
There was a problem hiding this comment.
I tried to get the sha512s to come back; that's why there's lockfileVersion being set here. Unfortunately it looks like this value comes from what is advertised by the feed when the package is published, and Azure DevOps feeds appear to advertise only the SHA1 value :(
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Dec 14, 2022
In microsoft#817 vestigial scripts to install "ce.ps1" and friends were removed, but smoke testing the 2022-12-13 release found that package.json still referred to them. Drive-by changed a few 'ce's to 'vcpkg-artifacts's.
BillyONeal
added a commit
that referenced
this pull request
Dec 14, 2022
In #817 vestigial scripts to install "ce.ps1" and friends were removed, but smoke testing the 2022-12-13 release found that package.json still referred to them. Drive-by changed a few 'ce's to 'vcpkg-artifacts's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.