Fix build breaks discovered on Node 18.x #818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about the exact cause of this failure but I suspect it's a change from node version since that's the only thing we've changed:
I'm pretty sure almost all of this compression code is filthy with how fds are treated; running the tests still gives:
In the medium term we will throw all of this out and feed it all to libarchive (either through linking vcpkg to libarchive ourselves or feeding it to
cmake -E tar
) but this targeted workaround gets my development working again.