-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace node downloader with vcpkg x-download. #826
Conversation
# Conflicts: # include/vcpkg/base/messages.h # src/vcpkg/base/messages.cpp # src/vcpkg/binarycaching.cpp
If you only want the progress in percentage you can use And
|
I did say that, and I still agree that is true. However, there's a very big difference in effect here. The worst thing that happens if the output changes and we parse the percentage incorrectly is funny ephemeral progress bar output. Nothing gets edited on disk or similar in the previous discussion where we were talking about mutating Would it be better to check for the presence of those first 2 lines that are the 'key'? The specific order is not documented to be contractual but that k/M/G/etc are 1024s is, see https://curl.se/docs/manpage.html Also asked curl's maintainer here: https://twitter.com/MalwareMinigun/status/1600570213572825090
It doesn't use
That's exactly why it doesn't use |
Daniel Stenberg clarified that it's at least semi-contractual here: https://twitter.com/bagder/status/1600615752725307400 |
# Conflicts: # include/vcpkg/base/messages.h # src/vcpkg/commands.xdownload.cpp
Thanks again so much @vicroms :) |
Resolves https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1494956.
This will also make artifacts respect asset caching settings if a SHA512 is provided.
vcpkg x-download
and removes all attempts to download from within Node.x-download
learns a new switch--z-machine-readable-progress
, which artifacts reads to power its progress bars.WinHttpQueryDataAvailable
.