Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overlays to configuration schema #832

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Add overlays to configuration schema #832

merged 1 commit into from
Dec 14, 2022

Conversation

gjasny
Copy link
Contributor

@gjasny gjasny commented Dec 14, 2022

BillyONeal
BillyONeal reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM iff the suggestion is applied.

BillyONeal
BillyONeal approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually LGTM period, I forgot this is a full path not just a name

@BillyONeal
Copy link
Member

Sorry I missed in #743

@BillyONeal BillyONeal merged commit 7ae0d85 into microsoft:main Dec 14, 2022
@BillyONeal
Copy link
Member

Thanks for your contribution to vcpkg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@valeriaconde valeriaconde valeriaconde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjasny @BillyONeal @valeriaconde