Fix unescaped curly braces in localized string #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
approved these changes
Jan 10, 2023
| "PortBugMissingLicense": "The software license must be available at ${CURRENT_PACKAGES_DIR}/share/{spec}/copyright", | ||
| "_PortBugMissingLicense.comment": "'{CURRENT_PACKAGES_DIR}' should not be translated. An example of {spec} is zlib:x64-windows.", | ||
| "PortBugMissingLicense": "The software license must be available at ${{CURRENT_PACKAGES_DIR}}/share/{spec}/copyright", | ||
| "_PortBugMissingLicense.comment": "An example of {spec} is zlib:x64-windows.", |
There was a problem hiding this comment.
This comment indicates that msg::spec isn't the best argument placeholder to use -- we probably should use msg::package_name instead.
There was a problem hiding this comment.
Noted, will add it as a drive-by fix in my export-port PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vcpkg#28845