pkgconfig post-build-check: Detect more problems, fix output and add e2e tests #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
force-pushed
the
feature/fix-pkgconfig-postbuildcheck
branch
from
9d4a79d to
978b65d
Compare
autoantwort
force-pushed
the
feature/fix-pkgconfig-postbuildcheck
branch
from
978b65d to
8bb5ebd
Compare
BillyONeal
requested changes
Feb 7, 2023
include/vcpkg/base/messages.h
Outdated
| (), | ||
| "Only the 'empty directories left by the above renames' part should be translated", | ||
| "vcpkg_fixup_pkgconfig()\nfile(REMOVE_RECURSE empty directories left by the above renames)"); | ||
| DECLARE_MESSAGE(PortBugRemoveEmptyDirs, (), "", "empty directories left by the above renames"); |
There was a problem hiding this comment.
I don't think this is actually an improvement: it is important for translators to be able to see the context for the message, and it isn't in general safe to just combine things after the fact.
I think the correct fix is just to delete the:
msg::write_unlocalized_text_to_stdout(Color::warning, " vcpkg_fixup_pkgconfig()\nfile(REMOVE_RECURSE ");
line instead.
There was a problem hiding this comment.
It is now file(REMOVE_RECURSE empty directories left by the above renames)
BillyONeal
approved these changes
Feb 11, 2023
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not all wrong placed files are detected. Also the output was broken after the localization. Added e2e tests to verify the new check