Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ee-ts dependency. #867

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Remove the ee-ts dependency. #867

merged 1 commit into from
Jan 24, 2023

Conversation

BillyONeal
Copy link
Member

Fixes signed builds. The previous prepare-deploy was attempting to remove what it thought was a phantom dependency on the typescript compiler from the deployed output. This failed because the DevDiv build lab pushed out changes that blocked the unrestrained dependency on rimraf used by that script. This change drops the dependency on ee-ts which created the need to include the typescript compiler in the first place.

Also fixed test failures that ee-ts was apparently hiding?!

Fixes signed builds. The previous prepare-deploy was attempting to remove what it thought was a phantom dependency on the typescript compiler from the deployed output. This failed because the DevDiv build lab pushed out changes that blocked the unrestrained dependency on rimraf used by that script. This change drops the dependency on ee-ts which created the need to include the typescript compiler in the first place.

Also fixed test failures that ee-ts was apparently hiding?!
@BillyONeal BillyONeal merged commit 8a88d63 into main Jan 24, 2023
@BillyONeal BillyONeal deleted the signed-build-fix branch January 24, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants