Avoid needing to triple escape paths in z-applocal tests. #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In microsoft#864 (comment) I noted that these tests fail on my machine before making any changes; I'm not sure why, but when I try to run with cmd manually (outside of vcpkg env) I get the same "the filename, directory name, or volume label syntax is incorrect" error that vcpkg env gives. This change just makes the batch files know the right path to use themselves rather than needing it passed in by the caller, so we don't need to deal with so many levels of confusing escaping.
|
To demonstrate that this escape confusion happens in |
JavierMatosD
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #864 (comment) I noted that these tests fail on my machine before making any changes; I'm not sure why, but when I try to run with cmd manually (outside of vcpkg env) I get the same "the filename, directory name, or volume label syntax is incorrect" error that vcpkg env gives.
This change just makes the batch files know the right path to use themselves rather than needing it passed in by the caller, so we don't need to deal with so many levels of confusing escaping.