Artifacts: Get rid of the markdown parser. #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were always just emitting the markdown output to the console. This feature was very expensive, both in terms of deployment size and in terms of execution time. When running `vcpkg find artifact gcc`, this change reduces the execution time from ~708 ms to ~378 ms, or 1.8 times as fast. It also cuts the deployed size of the ecmascript by 48%. (This is very close to letting us just embed the ecmascript directly which means we can avoid an extra download when someone touches artifacts)
|
Before: After: |
ras0219-msft
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always just emitting the markdown output to the console. This feature was very expensive, both in terms of deployment size and in terms of execution time.
When running
vcpkg find artifact gcc, this change reduces the execution time from ~708 ms to ~378 ms, or 1.8 times as fast. It also cuts the deployed size of the ecmascript by 48%. (This is very close to letting us just embed the ecmascript directly which means we can avoid an extra download when someone touches artifacts)I'm assuming the majority of the speedup is just due to node parsing less ecmascript. If we compare the old and new deployments side by side the top 1, 3, and 4 packages in terms of size (
lodash,marked, andesprima) are gone.Soon: YAML :)