-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 'expected a versioning field' error message #880
Improve 'expected a versioning field' error message #880
Conversation
4409add
to
e381a9e
Compare
Thanks for the PR!
|
@ras0219-msft I see. Thanks for your explanation! Should this PR be closed then or is it still valid? |
I think this is valid but we need to add version-string to the list. Also somehow we missed localizing this :( |
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Thanks! |
Imagine you try to commit a port with missing or invalid version field in manifest. You'd get an error like this:
However it seems that using of version-string is deprecated:
This PR makes error message consistent with lint warnings and shows all version-like fields available:
Before:
After: