Add warning message for change in default triplet to host triplet

include/vcpkg/base/messages.h

@@ -1009,6 +1009,12 @@ namespace vcpkg
     DECLARE_MESSAGE(DateTableHeader, (), "", "Date");
     DECLARE_MESSAGE(DefaultBrowserLaunched, (msg::url), "", "Default browser launched to {url}.");
     DECLARE_MESSAGE(DefaultFlag, (msg::option), "", "Defaulting to --{option} being on.");
+    DECLARE_MESSAGE(DefaultTriplet,
+                    (msg::triplet),
+                    "",
+                    "Starting with the September 2023 release, the default triplet for vcpkg libraries will change "
+                    "from x86-windows to the detected host triplet ({triplet}). To resolve this message, add --triplet "
+                    "x86-windows to keep the same behavior.");
     DECLARE_MESSAGE(DeleteVcpkgConfigFromManifest,
                     (msg::path),
                     "",

include/vcpkg/triplet.h

@@ -43,6 +43,7 @@ namespace vcpkg
 
     Triplet default_triplet(const VcpkgCmdArguments& args);
     Triplet default_host_triplet(const VcpkgCmdArguments& args);
+    void print_default_triplet_warning(const VcpkgCmdArguments& args, View<std::string> specs);
 }
 
 VCPKG_FORMAT_AS(vcpkg::Triplet, vcpkg::StringView);

locales/messages.json

@@ -324,6 +324,8 @@
   "_DefaultBrowserLaunched.comment": "An example of {url} is https://github.com/microsoft/vcpkg.",
   "DefaultFlag": "Defaulting to --{option} being on.",
   "_DefaultFlag.comment": "An example of {option} is editable.",
+  "DefaultTriplet": "Starting with the September 2023 release, the default triplet for vcpkg libraries will change from x86-windows to the detected host triplet ({triplet}). To resolve this message, add --triplet x86-windows to keep the same behavior.",
+  "_DefaultTriplet.comment": "An example of {triplet} is x64-windows.",
   "DeleteVcpkgConfigFromManifest": "-- Or remove \"vcpkg-configuration\" from the manifest file {path}.",
   "_DeleteVcpkgConfigFromManifest.comment": "An example of {path} is /foo/bar.",
   "DeprecatedPrefabDebugOption": "--prefab-debug is now deprecated.",

src/vcpkg/base/messages.cpp

@@ -627,6 +627,7 @@ namespace vcpkg
     REGISTER_MESSAGE(DateTableHeader);
     REGISTER_MESSAGE(DefaultBrowserLaunched);
     REGISTER_MESSAGE(DefaultFlag);
+    REGISTER_MESSAGE(DefaultTriplet);
     REGISTER_MESSAGE(DeleteVcpkgConfigFromManifest);
     REGISTER_MESSAGE(DeprecatedPrefabDebugOption);
     REGISTER_MESSAGE(DetectCompilerHash);

src/vcpkg/build.cpp

@@ -187,6 +187,7 @@ namespace vcpkg::Build
         BinaryCache binary_cache{args, paths};
         const FullPackageSpec spec = check_and_get_full_package_spec(
             std::move(first_arg), default_triplet, COMMAND_STRUCTURE.example_text, paths);
+        print_default_triplet_warning(args, {&args.command_arguments[0], 1});
 
         auto& fs = paths.get_filesystem();
         auto registry_set = paths.make_registry_set();

src/vcpkg/commands.check-support.cpp

@@ -112,6 +112,7 @@ namespace vcpkg::Commands
             return check_and_get_full_package_spec(
                 std::string(arg), default_triplet, COMMAND_STRUCTURE.example_text, paths);
         });
+        print_default_triplet_warning(args, args.command_arguments);
 
         auto& fs = paths.get_filesystem();
         auto registry_set = paths.make_registry_set();

src/vcpkg/commands.ci.cpp

@@ -334,6 +334,8 @@ namespace vcpkg::Commands::CI
     {
         msg::println_warning(msgInternalCICommand);
 
+        print_default_triplet_warning(args, {});
+
         const ParsedArguments options = args.parse_arguments(COMMAND_STRUCTURE);
         const auto& settings = options.settings;
 

src/vcpkg/commands.dependinfo.cpp

@@ -304,6 +304,7 @@ namespace vcpkg::Commands::DependInfo
             return check_and_get_full_package_spec(
                 std::string{arg}, default_triplet, COMMAND_STRUCTURE.example_text, paths);
         });
+        print_default_triplet_warning(args, args.command_arguments);
 
         auto& fs = paths.get_filesystem();
         auto registry_set = paths.make_registry_set();

src/vcpkg/commands.setinstalled.cpp

@@ -158,6 +158,7 @@ namespace vcpkg::Commands::SetInstalled
             return check_and_get_full_package_spec(
                 std::string(arg), default_triplet, COMMAND_STRUCTURE.example_text, paths);
         });
+        print_default_triplet_warning(args, args.command_arguments);
 
         BinaryCache binary_cache{args, paths};
 

src/vcpkg/commands.upgrade.cpp

@@ -117,6 +117,8 @@ namespace vcpkg::Commands::Upgrade
         }
         else
         {
+            print_default_triplet_warning(args, args.command_arguments);
+
             std::vector<PackageSpec> not_installed;
             std::vector<PackageSpec> no_control_file;
             std::vector<PackageSpec> to_upgrade;

src/vcpkg/export.cpp

@@ -418,6 +418,7 @@ namespace vcpkg::Export
                 return check_and_get_package_spec(
                     std::string(arg), default_triplet, COMMAND_STRUCTURE.example_text, paths);
             });
+            print_default_triplet_warning(args, args.command_arguments);
         }
 
         if (!ret.raw && !ret.nuget && !ret.ifw && !ret.zip && !ret.seven_zip && !ret.dry_run && !ret.chocolatey &&

src/vcpkg/install.cpp

@@ -991,6 +991,7 @@ namespace vcpkg
                 print_usage(MANIFEST_COMMAND_STRUCTURE);
                 Checks::exit_fail(VCPKG_LINE_INFO);
             }
+            print_default_triplet_warning(args, {});
         }
         else
         {
@@ -1188,6 +1189,7 @@ namespace vcpkg
             return check_and_get_full_package_spec(
                 std::string(arg), default_triplet, COMMAND_STRUCTURE.example_text, paths);
         });
+        print_default_triplet_warning(args, args.command_arguments);
 
         // create the plan
         msg::println(msgComputingInstallPlan);

src/vcpkg/remove.cpp

@@ -230,6 +230,7 @@ namespace vcpkg::Remove
                 return check_and_get_package_spec(
                     std::string(arg), default_triplet, COMMAND_STRUCTURE.example_text, paths);
             });
+            print_default_triplet_warning(args, args.command_arguments);
         }
 
         const bool no_purge = Util::Sets::contains(options.switches, OPTION_NO_PURGE);

src/vcpkg/triplet.cpp

@@ -1,5 +1,6 @@
 #include <vcpkg/base/strings.h>
 
+#include <vcpkg/packagespec.h>
 #include <vcpkg/triplet.h>
 #include <vcpkg/vcpkgcmdarguments.h>
 
@@ -112,4 +113,31 @@ namespace vcpkg
         }
         return system_triplet();
     }
+
+    void print_default_triplet_warning(const VcpkgCmdArguments& args, View<std::string> specs)
+    {
+        (void)args;
+        (void)specs;
+#if defined(_WIN32)
+        // The triplet is not set by --triplet or VCPKG_DEFAULT_TRIPLET
+        if (!args.triplet.has_value())
+        {
+            if (specs.size() == 0)
+            {
+                msg::println_warning(msgDefaultTriplet, msg::triplet = default_host_triplet(args));
+                return;
+            }
+            for (auto&& arg : specs)
+            {
+                const std::string as_lowercase = Strings::ascii_to_lowercase(std::string{arg});
+                auto maybe_qpkg = parse_qualified_specifier(as_lowercase);
+                if (maybe_qpkg.has_value() && !maybe_qpkg.get()->triplet.has_value())
+                {
+                    msg::println_warning(msgDefaultTriplet, msg::triplet = default_host_triplet(args));
+                    return;
+                }
+            }
+        }
+#endif
+    }
 }