-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vcpkg::print2 and vcpkg::printf localization leftovers. #889
Conversation
Hm changes
to
Which makes it unreadable imho |
The problem is that I don't think there is a good / practical way to express that formatting in a way localizers can handle. They need to see the context that these are all printed together in order to be able to translate it correctly. I think the main source of 'unreadability' here is that for some reason there is no word wrapping here but basically every terminal these days wraps? I guess we could add more blank lines... |
Hm ok. I am not a translator but it is really impossible to correctly only translate for example
|
tbl.text("NuGet's cache is not used by default. To use it for every nuget-based source, set the environment " | ||
"variable `VCPKG_USE_NUGET_CACHE` to `true` (case-insensitive) or `1`.\n"); | ||
tbl.blank(); | ||
print2(tbl.m_str); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we didn't lose the nice formatting here :(
However, I don't think there is another way to have nice formatting and provide the necessary context to the localizers.
FYI: Sorry I missed this!
# Conflicts: # include/vcpkg/dependencies.h # src/vcpkg/commands.dependinfo.cpp # src/vcpkg/commands.upgrade.cpp # src/vcpkg/dependencies.cpp # src/vcpkg/install.cpp
@autoantwort @ras0219-msft @JavierMatosD I put table formatting back; this is slightly less localizable and it's possible that we won't get away with it, but it's worth a shot. |
I changed ` in all the help topics to " because we said that ` has meaning by virtue of being an escape character. Otherwise they are copied into one big string verbatim.