Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary cache: async push_success #908

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from
Draft

Binary cache: async push_success #908

wants to merge 56 commits into from

Commits on Feb 15, 2023

  1. Binary cache: async push_success

    @autoantwort
    autoantwort committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    95f0438 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	src/vcpkg.cpp
    @autoantwort
    autoantwort committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    9d999d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success

    @autoantwort
    autoantwort committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    163d9cd View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
    @autoantwort @ras0219-msft
    autoantwort and ras0219-msft authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    2a54205 View commit details
    Browse the repository at this point in the history

  3. Adapt code review

    @autoantwort
    autoantwort committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    0912655 View commit details
    Browse the repository at this point in the history

  4. Update src/vcpkg/binarycaching.cpp 

    Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
    @autoantwort @ras0219-msft
    autoantwort and ras0219-msft authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5d7288c View commit details
    Browse the repository at this point in the history

  5. Adapt code review

    @autoantwort
    autoantwort committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    10189ac View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary actions_to_push_notifier.notify_all()

    @autoantwort
    autoantwort committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    2567607 View commit details
    Browse the repository at this point in the history

  7. Prevent deadlock and don't be on the crtl+c path

    @autoantwort
    autoantwort committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    ecdd000 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Add and use BGMessageSink to print IBinaryProvider::push_success mess… 

    …ages between package installs

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
    @autoantwort @ras0219-msft
    autoantwort and ras0219-msft committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    8e7ae61 View commit details
    Browse the repository at this point in the history

  2. Restore old upload message

    @autoantwort
    autoantwort committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    850d7c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Don't join yourself

    @autoantwort
    autoantwort committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    548be38 View commit details
    Browse the repository at this point in the history

  2. Print messages about remaining packages to upload

    @autoantwort
    autoantwort committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    6dbbf06 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. Localization

    @autoantwort
    autoantwort committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    74b86fd View commit details
    Browse the repository at this point in the history

  2. Improve messages

    @autoantwort
    autoantwort committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    5171d3e View commit details
    Browse the repository at this point in the history

  3. No singleton and explicit calls to wait_for_async_complete() 

    See microsoft#908 (comment)
    @autoantwort
    autoantwort committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    d69ed8f View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	src/vcpkg/build.cpp
    @autoantwort
    autoantwort committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2df42d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	src/vcpkg/base/messages.cpp
    @autoantwort
    autoantwort committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5f1786e View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success

    @autoantwort
    autoantwort committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    93303c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	include/vcpkg/base/messages.h
#	src/vcpkg/base/messages.cpp
    @autoantwort
    autoantwort committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    8a26c8b View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success

    @autoantwort
    autoantwort committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    aa7e52f View commit details
    Browse the repository at this point in the history

  2. Apply code review

    @autoantwort
    autoantwort committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d46a4d6 View commit details
    Browse the repository at this point in the history

  3. Trigger Build

    @autoantwort
    autoantwort committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    5e51718 View commit details
    Browse the repository at this point in the history

  4. No rename dance

    @autoantwort
    autoantwort committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    a9ac558 View commit details
    Browse the repository at this point in the history

  5. Print upload to provider only once and not once per provider

    @autoantwort
    autoantwort committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    4faf674 View commit details
    Browse the repository at this point in the history

  6. Fix tests

    @autoantwort
    autoantwort committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    b9be8c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Don't create unnecessary strings

    @autoantwort
    autoantwort committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    78ca081 View commit details
    Browse the repository at this point in the history

  2. Rename to m_published_lock

    @autoantwort
    autoantwort committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    579bfa9 View commit details
    Browse the repository at this point in the history

  3. BinaryPackageInformation use Optional and make BinaryProviderPushRequ… 

    …est a aggregate
    @autoantwort
    autoantwort committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    103968e View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success and … 

    …add BatchQuere

# Conflicts:
#	include/vcpkg/base/message-data.inc.h
#	include/vcpkg/base/strings.h
#	include/vcpkg/binarycaching.h
#	include/vcpkg/binarycaching.private.h
#	include/vcpkg/fwd/binarycaching.h
#	locales/messages.json
#	src/vcpkg-test/binarycaching.cpp
#	src/vcpkg/binarycaching.cpp
#	src/vcpkg/commands.build.cpp
#	src/vcpkg/commands.install.cpp
    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    dd32416 View commit details
    Browse the repository at this point in the history

  2. Add missing files

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    b666f94 View commit details
    Browse the repository at this point in the history

  3. Add missing includes

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    15bb503 View commit details
    Browse the repository at this point in the history

  4. Make BianryCache a unique_ptr

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d995bfd View commit details
    Browse the repository at this point in the history

  5. Reduce changes

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    24cd026 View commit details
    Browse the repository at this point in the history

  6. Fix output

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    92fc76b View commit details
    Browse the repository at this point in the history

  7. Fix bug

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3527227 View commit details
    Browse the repository at this point in the history

  8. Format

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    48305b3 View commit details
    Browse the repository at this point in the history

  9. Use lock_guard

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    27fa076 View commit details
    Browse the repository at this point in the history

  10. Revert "Use lock_guard" 

    This reverts commit 27fa076.
    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    bcd459a View commit details
    Browse the repository at this point in the history

  11. Use enum

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f958d36 View commit details
    Browse the repository at this point in the history

  12. BGMessageSink::print_published apply code review

    @autoantwort
    autoantwort committed May 31, 2023
    Configuration menu
    Copy the full SHA
    7a24007 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	src/vcpkg/binarycaching.cpp
    @autoantwort
    autoantwort committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    50114f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	src/vcpkg/commands.ci.cpp
    @autoantwort
    autoantwort committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    ca5f2b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Fix typo

    @autoantwort
    autoantwort committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    eccd9ee View commit details
    Browse the repository at this point in the history

  2. Fix typo in file name

    @autoantwort
    autoantwort committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e7837e0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	src/vcpkg/commands.ci.cpp
#	src/vcpkg/commands.install.cpp
#	src/vcpkg/commands.set-installed.cpp
#	src/vcpkg/commands.upgrade.cpp
    @autoantwort
    autoantwort committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    969e7fc View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success

    @autoantwort
    autoantwort committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2d5586f View commit details
    Browse the repository at this point in the history

  2. Renamings

    @autoantwort
    autoantwort committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    809d0b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. format

    @autoantwort
    autoantwort committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    455e29b View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	include/vcpkg/base/message-data.inc.h
#	locales/messages.json
    @autoantwort
    autoantwort committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    03fdfea View commit details
    Browse the repository at this point in the history

  2. BinaryCache and std::unique_ptr

    @autoantwort
    autoantwort committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    f4bad8c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success

    @autoantwort
    autoantwort committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    26bbbd5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. BinaryCache: save data in std::unique_ptr so that the object can be m… 

    …oved while the data is accessed from a thread
    @autoantwort
    autoantwort committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    814e434 View commit details
    Browse the repository at this point in the history

  2. fix

    @autoantwort
    autoantwort committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    290e586 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge branch 'main' into feature/async-binary-cache-push-success 

    # Conflicts:
#	src/vcpkg/binarycaching.cpp
    @autoantwort
    autoantwort committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3cc3378 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'main' into feature/async-binary-cache-push-success

    @autoantwort
    autoantwort committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    978ceae View commit details
    Browse the repository at this point in the history