You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
With the freetype 2.10.2 update merged in #11846, support for WOFF 2 fonts was added but not accounted for when I updated the port. Thus, depending on whether brotli is already installed, it might be detected, support compiled, and linked in. The vcpkg brotli port does not export the library as BrotliDec like freetype expects, but as unofficial::brotli::brotli-SOMETHING, and I'm not sure why it's configured in this way.
Proposed solution
Add an optional feature brotli to control FT_WITH_BROTLI and CMAKE_DISABLE_FIND_PACKAGE_BrotliDec. Then either freetype must be patched to use the unofficial vcpkg CMake module names for brotli, or the unofficial CMake module names for brotli should be removed in favour of the official ones. I'm not sure why the unofficial names were added in the first place two years ago 33286f9.
Describe alternatives you've considered
Disable brotli support entirely like with HarfBuzz. Doesn't seem like a good idea to throw out an entire feature.
Additional context
I think #9838 might be related with the brotli CMake module names.
The text was updated successfully, but these errors were encountered:
Hmm i actually touched this issue in #11776. The problem is that the pkgconfig file for brotli is incorrect which is why it is not found by freetype. freetype itself uses a FindBrotliDec module which internally uses FindPkgConfig for brotli.
Is your feature request related to a problem? Please describe.
With the freetype 2.10.2 update merged in #11846, support for WOFF 2 fonts was added but not accounted for when I updated the port. Thus, depending on whether brotli is already installed, it might be detected, support compiled, and linked in. The vcpkg brotli port does not export the library as
BrotliDec
like freetype expects, but asunofficial::brotli::brotli-SOMETHING
, and I'm not sure why it's configured in this way.Proposed solution
Add an optional feature
brotli
to controlFT_WITH_BROTLI
andCMAKE_DISABLE_FIND_PACKAGE_BrotliDec
. Then either freetype must be patched to use the unofficial vcpkg CMake module names for brotli, or the unofficial CMake module names for brotli should be removed in favour of the official ones. I'm not sure why the unofficial names were added in the first place two years ago 33286f9.Describe alternatives you've considered
Disable brotli support entirely like with HarfBuzz. Doesn't seem like a good idea to throw out an entire feature.
Additional context
I think #9838 might be related with the brotli CMake module names.
The text was updated successfully, but these errors were encountered: